GH-45892: [Ruby] Unify test for list array in raw_records and each_raw_record#45940
Merged
kou merged 1 commit intoapache:mainfrom Mar 27, 2025
Merged
Conversation
…ach_raw_record ### Rationale for this change The PR reduces duplicated test cases and ensures that both `raw_records` and `each_raw_record` behave consistently by extracting their common test cases. - `Arrow::RecordBatch#each_raw_record` - `Arrow::Table#each_raw_record` - `Arrow::RecordBatch#raw_records` - `Arrow::Table#raw_records` ### What changes are included in this PR? We extracted shared test cases about list array used by both raw_records and each_raw_record. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: close apacheGH-45892
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0355ad6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 42 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
…ach_raw_record (apache#45940) ### Rationale for this change The PR reduces duplicated test cases and ensures that both `raw_records` and `each_raw_record` behave consistently by extracting their common test cases. - `Arrow::RecordBatch#each_raw_record` - `Arrow::Table#each_raw_record` - `Arrow::RecordBatch#raw_records` - `Arrow::Table#raw_records` ### What changes are included in this PR? We extracted shared test cases about list array used by both `raw_records` and `each_raw_record`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: close apacheGH-45892 * GitHub Issue: apache#45892 Authored-by: otegami <a.s.takuya1026@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The PR reduces duplicated test cases and ensures that both
raw_recordsandeach_raw_recordbehave consistently by extracting their common test cases.Arrow::RecordBatch#each_raw_recordArrow::Table#each_raw_recordArrow::RecordBatch#raw_recordsArrow::Table#raw_recordsWhat changes are included in this PR?
We extracted shared test cases about list array used by both
raw_recordsandeach_raw_record.Are these changes tested?
Yes.
Are there any user-facing changes?
No.