ARROW-5653: [C++] Ensure testing libraries are not installed#4635
Closed
fsaintjacques wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-5653: [C++] Ensure testing libraries are not installed#4635fsaintjacques wants to merge 2 commits intoapache:masterfrom
fsaintjacques wants to merge 2 commits intoapache:masterfrom
Conversation
ARROW_TEST_*_LINK_LIBS is already included via the add_arrow_test function.
libarrow_testing and libarrow_flight_testing should not be installed. Also fix the unit tests with LD_LIBRARY_PATH due to install target and cmake handling of RPATH.
Member
|
@ursabot crossbow test docker |
|
AMD64 Conda Crossbow (#22682) builder has been succeeded. Revision: 10f4e1f Submitted crossbow builds: ursa-labs/crossbow @ ursabot-31 |
Member
|
Looks like macOS is setting the install rpath in the executables |
Contributor
Author
|
I'll close this in favor of #4605 |
|
Why was this closed? |
Member
|
Can you please open a Jira issue? To make sure this is fixed |
This was referenced Dec 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libarrow_testing and libarrow_flight_testing should not be installed.
Also fix the unit tests with LD_LIBRARY_PATH due to install target and
cmake handling of RPATH.