GH-46433: [GLib] Add GArrowFixedShapeDataType#dim_names #46434
Merged
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
reviewed
May 14, 2025
github-actions
bot
added
awaiting changes
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 83f66d4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced May 15, 2025
kou
pushed a commit
that referenced
this pull request
May 16, 2025
### Rationale for this change #46434, #46401, #46381 implemented some instance methods for `GArrowFixedShapeTensorDataType` class. In method comment, a `since` tag was required, but I forgot to add it. ### What changes are included in this PR? Add `Since:` tags. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. (Add comment only) * GitHub Issue: #46456 Authored-by: Hiroyuki Sato <hiroysato@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The C++ API implemented
FixedShapeTensor::dim_names()instance method. GLib was not yet supported.What changes are included in this PR?
Add
GArrowFixedShapeDataType#dim_namesinstance method.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.