-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-46349: [Python] Move parquet definitions to pyarrow/includes/libparquet.pxd #46437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit -g python |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheelcp311 |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g python |
|
@github-actions crossbow submit wheelcp310 |
|
Revision: 83dbbab Submitted crossbow builds: ursacomputing/crossbow @ actions-1299dc12ed |
|
Revision: 83dbbab Submitted crossbow builds: ursacomputing/crossbow @ actions-84c0dabebe |
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you @raulcd
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b71f629. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Follow the convention we have for Arrow C++ API declarations which are are stored in pyarrow/includes/libxxx.pxd, with the specific name depending on the C++ component (for example pyarrow/includes/libarrow_dataset.pxd).
This follows the architecture defined:
https://arrow.apache.org/docs/python/getting_involved.html#pyarrow-architecture
What changes are included in this PR?
Move the Parquet C++ API declarations to
pyarrow/includes/libparquet.pxd.Are these changes tested?
Yes via CI and archery extended Python jobs.
Are there any user-facing changes?
No
pyarrow/_parquet.pxdshould go intopyarrow/includes#46349