Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented May 14, 2025

Rationale for this change

Follow the convention we have for Arrow C++ API declarations which are are stored in pyarrow/includes/libxxx.pxd, with the specific name depending on the C++ component (for example pyarrow/includes/libarrow_dataset.pxd).
This follows the architecture defined:
https://arrow.apache.org/docs/python/getting_involved.html#pyarrow-architecture

What changes are included in this PR?

Move the Parquet C++ API declarations to pyarrow/includes/libparquet.pxd.

Are these changes tested?

Yes via CI and archery extended Python jobs.

Are there any user-facing changes?

No

@raulcd
Copy link
Member Author

raulcd commented May 14, 2025

@github-actions crossbow submit -g python

@github-actions

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented May 14, 2025

@github-actions crossbow submit wheelcp311

@github-actions

This comment was marked as outdated.

@raulcd raulcd marked this pull request as ready for review May 14, 2025 11:17
@raulcd raulcd requested review from AlenkaF and rok as code owners May 14, 2025 11:18
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 14, 2025
@raulcd
Copy link
Member Author

raulcd commented May 14, 2025

@github-actions crossbow submit -g python

@raulcd
Copy link
Member Author

raulcd commented May 14, 2025

@github-actions crossbow submit wheelcp310

@github-actions
Copy link

Revision: 83dbbab

Submitted crossbow builds: ursacomputing/crossbow @ actions-1299dc12ed

Task Status
wheel-macos-monterey-cp310-cp310-amd64 GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-arm64 GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64 GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64 GitHub Actions
wheel-windows-cp310-cp310-amd64 GitHub Actions

@github-actions
Copy link

Revision: 83dbbab

Submitted crossbow builds: ursacomputing/crossbow @ actions-84c0dabebe

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@raulcd raulcd requested a review from pitrou May 15, 2025 08:13
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @raulcd

@pitrou pitrou merged commit b71f629 into apache:main May 15, 2025
14 of 15 checks passed
@pitrou pitrou removed the awaiting merge Awaiting merge label May 15, 2025
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 15, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b71f629.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants