Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented May 16, 2025

Rationale for this change

The current Meson configuration needs to be updated with these changes to work

What changes are included in this PR?

Small fixes to the Meson configuration files

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #46478 has been automatically assigned in GitHub to PR creator.

@WillAyd
Copy link
Contributor Author

WillAyd commented May 16, 2025

@github-actions crossbow submit *meson

@github-actions
Copy link

Revision: 819b969

Submitted crossbow builds: ursacomputing/crossbow @ actions-f1f61896f0

Task Status
test-conda-cpp-meson GitHub Actions

@WillAyd
Copy link
Contributor Author

WillAyd commented May 16, 2025

Hey @amoeba this is a small follow up to some of your great work in #46180 - let me know if anything looks off

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 17, 2025
@kou kou merged commit 7c67690 into apache:main May 17, 2025
34 of 37 checks passed
@kou kou removed the awaiting merge Awaiting merge label May 17, 2025
@WillAyd WillAyd deleted the meson-fix-ipc-configuration branch May 17, 2025 14:08
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7c67690.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

@amoeba
Copy link
Member

amoeba commented May 20, 2025

Thanks for this @WillAyd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants