ARROW-5637: [Java][C++][Gandiva] Complete In Expression Support#4662
Closed
praveenbingo wants to merge 5 commits intoapache:masterfrom
Closed
ARROW-5637: [Java][C++][Gandiva] Complete In Expression Support#4662praveenbingo wants to merge 5 commits intoapache:masterfrom
praveenbingo wants to merge 5 commits intoapache:masterfrom
Conversation
praveenbingo
changed the title
pravindra
reviewed
Jun 23, 2019
| return TreeExprBuilder::MakeInExpressionBinary(field, stringvalues); | ||
| } | ||
| // not supported yet. | ||
| return nullptr; |
Contributor
There was a problem hiding this comment.
pls add an error message / exception.
| private final Set<byte[]> binaryValues; | ||
| private final Field field; | ||
|
|
||
| private InNode(Set<Integer> values, Set<Long> longValues, Set<String> stringValues, Set<byte[]> |
Contributor
There was a problem hiding this comment.
this looks a bit ugly - but I guess there's no easy way to restrict the types.
Contributor
Author
There was a problem hiding this comment.
yeah..templates can be used but we would still need some way to build the protobuf.
| } | ||
|
|
||
| @Test | ||
| public void testInExpr() throws GandivaException, Exception { |
Contributor
There was a problem hiding this comment.
add a test with strings too ?
pravindra
reviewed
Jun 23, 2019
java/gandiva/pom.xml
Outdated
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <protobuf.version>2.5.0</protobuf.version> | ||
| <protobuf.version>2.6.1</protobuf.version> |
Contributor
There was a problem hiding this comment.
sorry, missed this earlier. This could impact Dremio because it uses a different protobuf version. Can you please move the protobuf version change to a different PR ?
Contributor
Author
There was a problem hiding this comment.
sounds good..reverting this back.
e Please enter the commit message for your changes. Lines starting
pravindra
approved these changes
Jun 23, 2019
wesm
changed the title
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Complete the java and jni bindings for In expression. Author: Praveen <praveen@dremio.com> Closes apache#4662 from praveenbingo/in-expr and squashes the following commits: 82e1d34 <Praveen> Fix lint issues. ce51188 <Praveen> Fix review comments. d204f0d <Praveen> Address Review comments. 7722fa5 <Praveen> Fixed lint issues. d2c448c <Praveen> Complete In Expression Support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the java and jni bindings for In expression.