Skip to content

Conversation

@romainfrancois
Copy link
Contributor

This adds this method to parquet::arrow::FileReader :

/// \brief Return arrow schema for all the columns.
  ::arrow::Status GetSchema(std::shared_ptr<::arrow::Schema>* out);

might be useful for e.g. #4627

@nealrichardson
Copy link
Member

Seems uncontroversial on the surface, but shouldn't there be a test added for it?

@wesm
Copy link
Member

wesm commented Jun 24, 2019

Agree that it doesn't seem controversial. A simple unit test and fixing the build seems in order

@wesm wesm force-pushed the ARROW-5702/FileReader_GetSchema branch from 7e8f6bd to 66dac6f Compare June 25, 2019 19:09
@wesm
Copy link
Member

wesm commented Jun 25, 2019

I fixed this and added a usage to a unit test

@wesm
Copy link
Member

wesm commented Jun 26, 2019

+1. This change isn't causing the other failures we're seeing

@wesm wesm closed this in 58c8902 Jun 26, 2019
@romainfrancois
Copy link
Contributor Author

Thanks. Sorry I did not get a chance to get back to it soon enough.

@romainfrancois romainfrancois deleted the ARROW-5702/FileReader_GetSchema branch June 26, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants