Skip to content

ARROW-5700: [C++] Try to produce better errors on Windows #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitrou wants to merge 1 commit into from
Closed

ARROW-5700: [C++] Try to produce better errors on Windows #4724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cpp/src/arrow/util/io-util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,13 @@ static inline Status CheckFileOpResult(int ret, int errno_actual,
const PlatformFilename& file_name,
const char* opname) {
if (ret == -1) {
#ifdef _WIN32
int winerr = GetLastError();
if (winerr != ERROR_SUCCESS) {
return Status::IOError("Failed to ", opname, " file '", file_name.ToString(),
"', error: ", WinErrorMessage(winerr));
}
#endif
return Status::IOError("Failed to ", opname, " file '", file_name.ToString(),
"', error: ", ErrnoMessage(errno_actual));
}
Expand All @@ -416,6 +423,7 @@ static inline Status CheckFileOpResult(int ret, int errno_actual,
Status FileOpenReadable(const PlatformFilename& file_name, int* fd) {
int ret, errno_actual;
#if defined(_WIN32)
SetLastError(0);
errno_actual = _wsopen_s(fd, file_name.ToNative().c_str(),
_O_RDONLY | _O_BINARY | _O_NOINHERIT, _SH_DENYNO, _S_IREAD);
ret = *fd;
Expand Down Expand Up @@ -446,6 +454,7 @@ Status FileOpenWritable(const PlatformFilename& file_name, bool write_only, bool
int ret, errno_actual;

#if defined(_WIN32)
SetLastError(0);
int oflag = _O_CREAT | _O_BINARY | _O_NOINHERIT;
int pmode = _S_IREAD | _S_IWRITE;

Expand Down