ARROW-749: [Python] Delete partially-written Feather file when column write fails#484
Closed
wesm wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-749: [Python] Delete partially-written Feather file when column write fails#484wesm wants to merge 1 commit intoapache:masterfrom
wesm wants to merge 1 commit intoapache:masterfrom
Conversation
Change-Id: I674fc3b4d34e57353655df262b09d43a49e65592
xhochy
approved these changes
Apr 3, 2017
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
I split the changes into multiple commits to ease the review. Used the example program to test the new API. I will add unit tests once we converge on the API after review. Thanks to @AnatoliShein for collaborating with the API design. Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#484 from majetideepak/PARQUET-1372 and squashes the following commits: 143ed51 [Deepak Majeti] improve comments c10fe08 [Deepak Majeti] Add test d12b10b [Deepak Majeti] Review comments cb99b3f [Deepak Majeti] fix compiler warnings e179a4c [Deepak Majeti] add example header 710bbe0 [Deepak Majeti] clang format 9e03004 [Deepak Majeti] reorg examples 410a3af [Deepak Majeti] remove flush_on_close e148817 [Deepak Majeti] add BufferedPageWriter 26a52c1 [Deepak Majeti] clang format 20049c0 [Deepak Majeti] modify examples 9db26a2 [Deepak Majeti] Combine RowGroupWriter2 with RowGroupWriter cb7d69c [Deepak Majeti] fix compiler errors 21642b3 [Deepak Majeti] clang format 530b835 [Deepak Majeti] example for RowGroupWriter2 0fc1f5c [Deepak Majeti] Extend Column Writer to flush pages on Close f2f420d [Deepak Majeti] RowGroupWriter2, implementation that writes all columns at once Change-Id: I4dab47d9991786eab9602293e50198b166d99e96
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 27, 2018
I split the changes into multiple commits to ease the review. Used the example program to test the new API. I will add unit tests once we converge on the API after review. Thanks to @AnatoliShein for collaborating with the API design. Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#484 from majetideepak/PARQUET-1372 and squashes the following commits: 143ed51 [Deepak Majeti] improve comments c10fe08 [Deepak Majeti] Add test d12b10b [Deepak Majeti] Review comments cb99b3f [Deepak Majeti] fix compiler warnings e179a4c [Deepak Majeti] add example header 710bbe0 [Deepak Majeti] clang format 9e03004 [Deepak Majeti] reorg examples 410a3af [Deepak Majeti] remove flush_on_close e148817 [Deepak Majeti] add BufferedPageWriter 26a52c1 [Deepak Majeti] clang format 20049c0 [Deepak Majeti] modify examples 9db26a2 [Deepak Majeti] Combine RowGroupWriter2 with RowGroupWriter cb7d69c [Deepak Majeti] fix compiler errors 21642b3 [Deepak Majeti] clang format 530b835 [Deepak Majeti] example for RowGroupWriter2 0fc1f5c [Deepak Majeti] Extend Column Writer to flush pages on Close f2f420d [Deepak Majeti] RowGroupWriter2, implementation that writes all columns at once Change-Id: I749cbde733780c9a6499df6738b2236124b8a9f7
wesm
pushed a commit
that referenced
this pull request
Sep 27, 2018
I split the changes into multiple commits to ease the review. Used the example program to test the new API. I will add unit tests once we converge on the API after review. Thanks to @AnatoliShein for collaborating with the API design. Author: Deepak Majeti <deepak.majeti@hpe.com> Closes #484 from majetideepak/PARQUET-1372 and squashes the following commits: 143ed51 [Deepak Majeti] improve comments c10fe08 [Deepak Majeti] Add test d12b10b [Deepak Majeti] Review comments cb99b3f [Deepak Majeti] fix compiler warnings e179a4c [Deepak Majeti] add example header 710bbe0 [Deepak Majeti] clang format 9e03004 [Deepak Majeti] reorg examples 410a3af [Deepak Majeti] remove flush_on_close e148817 [Deepak Majeti] add BufferedPageWriter 26a52c1 [Deepak Majeti] clang format 20049c0 [Deepak Majeti] modify examples 9db26a2 [Deepak Majeti] Combine RowGroupWriter2 with RowGroupWriter cb7d69c [Deepak Majeti] fix compiler errors 21642b3 [Deepak Majeti] clang format 530b835 [Deepak Majeti] example for RowGroupWriter2 0fc1f5c [Deepak Majeti] Extend Column Writer to flush pages on Close f2f420d [Deepak Majeti] RowGroupWriter2, implementation that writes all columns at once Change-Id: I749cbde733780c9a6499df6738b2236124b8a9f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently the only place where we are doing an atomic create-file/write-file. We should be mindful of other serialization functions which may yield unreadable files in the future.