GH-48844: [C++] Check IPC Message body length consistency in IPC file #48845
+21
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
changed the title
pitrou
force-pushed
the
ipc-check-body-length
branch
2 times, most recently
from
2a29297 to
e893e27
Compare
pitrou
changed the title
emkornfield
reviewed
Jan 13, 2026
github-actions
bot
added
awaiting changes
pitrou
force-pushed
the
ipc-check-body-length
branch
from
e893e27 to
9ee2f5e
Compare
github-actions
bot
added
awaiting change review
emkornfield
approved these changes
Jan 13, 2026
github-actions
bot
added
awaiting merge
Member
Author
|
The occasional integration test failure is unrelated, see apache/arrow-js#15 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit fed23f3. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The IPC file exposes redundant information about Message sizes so as to allow for random access from the file footer.
We tried adding consistency checks in the past but this hit a bug in the JavaScript IPC writer at the time, so the checks were left disabled.
The JavaScript implementation was fixed soon after (7 years ago), so this PR re-enables those checks so as to more easily detect potentially invalid IPC files.
Are these changes tested?
By existing tests.
Are there any user-facing changes?
No, unless they try reading invalid IPC files.