GH-49263: [Python][CI] Install rust compiler for libcst only on Debian 32 bits#49265
GH-49263: [Python][CI] Install rust compiler for libcst only on Debian 32 bits#49265raulcd wants to merge 2 commits intoapache:mainfrom
Conversation
… Debian 32 bits as wheel is not provided
|
|
|
@github-actions crossbow submit test-debian-13-python-3-i386 |
|
Revision: 6847715 Submitted crossbow builds: ursacomputing/crossbow @ actions-5e74de75da
|
|
@github-actions crossbow submit test-debian-13-python-3-i386 |
|
Revision: 05b3a6c Submitted crossbow builds: ursacomputing/crossbow @ actions-d6beb74d9e
|
| tzdata \ | ||
| tzdata-legacy \ | ||
| zlib1g-dev && \ | ||
| if [ ${arch} = "i386" ]; then \ |
There was a problem hiding this comment.
@kou I decided to add this here instead of on the debian-python one because we do not install any debian packages there and we install everything on this base. Let me know if you would prefer us to have this dependency there instead I am 50-50 on where should this go.
There was a problem hiding this comment.
I'm OK with installing Rust here.
BTW, how about always installing Rust instead of checking ${arch} = "i386"?
diff --git a/ci/docker/debian-13-cpp.dockerfile b/ci/docker/debian-13-cpp.dockerfile
index fe947db025..928443ee64 100644
--- a/ci/docker/debian-13-cpp.dockerfile
+++ b/ci/docker/debian-13-cpp.dockerfile
@@ -42,6 +42,7 @@ RUN apt-get update -y -q && \
apt-get update -y -q && \
apt-get install -y -q --no-install-recommends \
autoconf \
+ cargo \
ccache \
clang-${llvm} \
cmake \
@@ -86,6 +87,7 @@ RUN apt-get update -y -q && \
python3-venv \
rapidjson-dev \
rsync \
+ rust \
tzdata \
tzdata-legacy \
zlib1g-dev && \I know that we don't need Rust for the armd64 platform but no ${arch} check will simplify our Dockerfile.
| tzdata \ | ||
| tzdata-legacy \ | ||
| zlib1g-dev && \ | ||
| if [ ${arch} = "i386" ]; then \ |
There was a problem hiding this comment.
I'm OK with installing Rust here.
BTW, how about always installing Rust instead of checking ${arch} = "i386"?
diff --git a/ci/docker/debian-13-cpp.dockerfile b/ci/docker/debian-13-cpp.dockerfile
index fe947db025..928443ee64 100644
--- a/ci/docker/debian-13-cpp.dockerfile
+++ b/ci/docker/debian-13-cpp.dockerfile
@@ -42,6 +42,7 @@ RUN apt-get update -y -q && \
apt-get update -y -q && \
apt-get install -y -q --no-install-recommends \
autoconf \
+ cargo \
ccache \
clang-${llvm} \
cmake \
@@ -86,6 +87,7 @@ RUN apt-get update -y -q && \
python3-venv \
rapidjson-dev \
rsync \
+ rust \
tzdata \
tzdata-legacy \
zlib1g-dev && \I know that we don't need Rust for the armd64 platform but no ${arch} check will simplify our Dockerfile.
Rationale for this change
In order to automate docstrings and build type hints we require libcst. libcst does not provide wheels for Debian 32 and we have to build from source distribution. In order to build from sdist we require a rust compiler available.
What changes are included in this PR?
Install rust on Debian i386.
Are these changes tested?
Yes via archery
Are there any user-facing changes?
No