ARROW-6017: [FlightRPC] Enable creating Flight Locations for unknown schemes · Pull Request #4928 · apache/arrow

ghost · 2019-07-23T18:09:36Z

The motivation is to enable interop with future Flight versions that may support different transports, and to enable a Flight service to reference a non-Flight service.

Personal Travis: https://travis-ci.com/lihalite/arrow/builds/120257110
AppVeyor: https://ci.appveyor.com/project/lihalite/arrow/builds/26189055

codecov-io · 2019-07-24T11:07:10Z

Codecov Report

Merging #4928 into master will increase coverage by 1.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   87.45%   89.07%   +1.61%     
==========================================
  Files         994      717     -277     
  Lines      140389   100261   -40128     
  Branches     1418        0    -1418     
==========================================
- Hits       122778    89307   -33471     
+ Misses      17249    10954    -6295     
+ Partials      362        0     -362

Impacted Files	Coverage Δ
python/pyarrow/tests/test_flight.py	`70.54% <100%> (+0.2%)`	⬆️
cpp/src/arrow/flight/flight-test.cc	`97.81% <100%> (+0.01%)`	⬆️
cpp/src/plasma/thirdparty/ae/ae.c	`70.75% <0%> (-0.95%)`	⬇️
go/arrow/ipc/writer.go
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2746a23...99c0207. Read the comment docs.

codecov-io · 2019-07-24T11:07:10Z

Codecov Report

Merging #4928 into master will increase coverage by 1.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   87.45%   89.07%   +1.61%     
==========================================
  Files         994      717     -277     
  Lines      140389   100261   -40128     
  Branches     1418        0    -1418     
==========================================
- Hits       122778    89307   -33471     
+ Misses      17249    10954    -6295     
+ Partials      362        0     -362

Impacted Files	Coverage Δ
python/pyarrow/tests/test_flight.py	`70.54% <100%> (+0.2%)`	⬆️
cpp/src/arrow/flight/flight-test.cc	`97.81% <100%> (+0.01%)`	⬆️
cpp/src/plasma/thirdparty/ae/ae.c	`70.75% <0%> (-0.95%)`	⬇️
go/arrow/ipc/writer.go
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2746a23...99c0207. Read the comment docs.

codecov-io · 2019-07-24T11:07:10Z

Codecov Report

Merging #4928 into master will increase coverage by 1.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   87.45%   89.07%   +1.61%     
==========================================
  Files         994      717     -277     
  Lines      140389   100261   -40128     
  Branches     1418        0    -1418     
==========================================
- Hits       122778    89307   -33471     
+ Misses      17249    10954    -6295     
+ Partials      362        0     -362

Impacted Files	Coverage Δ
python/pyarrow/tests/test_flight.py	`70.54% <100%> (+0.2%)`	⬆️
cpp/src/arrow/flight/flight-test.cc	`97.81% <100%> (+0.01%)`	⬆️
cpp/src/plasma/thirdparty/ae/ae.c	`70.75% <0%> (-0.95%)`	⬇️
go/arrow/ipc/writer.go
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2746a23...99c0207. Read the comment docs.

codecov-io · 2019-07-24T11:07:10Z

Codecov Report

Merging #4928 into master will increase coverage by 1.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   87.45%   89.07%   +1.61%     
==========================================
  Files         994      717     -277     
  Lines      140389   100261   -40128     
  Branches     1418        0    -1418     
==========================================
- Hits       122778    89307   -33471     
+ Misses      17249    10954    -6295     
+ Partials      362        0     -362

Impacted Files	Coverage Δ
python/pyarrow/tests/test_flight.py	`70.54% <100%> (+0.2%)`	⬆️
cpp/src/arrow/flight/flight-test.cc	`97.81% <100%> (+0.01%)`	⬆️
cpp/src/plasma/thirdparty/ae/ae.c	`70.75% <0%> (-0.95%)`	⬇️
go/arrow/ipc/writer.go
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2746a23...99c0207. Read the comment docs.

codecov-io · 2019-07-24T11:07:10Z

Codecov Report

Merging #4928 into master will increase coverage by 1.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   87.45%   89.07%   +1.61%     
==========================================
  Files         994      717     -277     
  Lines      140389   100261   -40128     
  Branches     1418        0    -1418     
==========================================
- Hits       122778    89307   -33471     
+ Misses      17249    10954    -6295     
+ Partials      362        0     -362

Impacted Files	Coverage Δ
python/pyarrow/tests/test_flight.py	`70.54% <100%> (+0.2%)`	⬆️
cpp/src/arrow/flight/flight-test.cc	`97.81% <100%> (+0.01%)`	⬆️
cpp/src/plasma/thirdparty/ae/ae.c	`70.75% <0%> (-0.95%)`	⬇️
go/arrow/ipc/writer.go
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2746a23...99c0207. Read the comment docs.

codecov-io · 2019-07-24T11:07:10Z

Codecov Report

Merging #4928 into master will increase coverage by 1.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   87.45%   89.07%   +1.61%     
==========================================
  Files         994      717     -277     
  Lines      140389   100261   -40128     
  Branches     1418        0    -1418     
==========================================
- Hits       122778    89307   -33471     
+ Misses      17249    10954    -6295     
+ Partials      362        0     -362

Impacted Files	Coverage Δ
python/pyarrow/tests/test_flight.py	`70.54% <100%> (+0.2%)`	⬆️
cpp/src/arrow/flight/flight-test.cc	`97.81% <100%> (+0.01%)`	⬆️
cpp/src/plasma/thirdparty/ae/ae.c	`70.75% <0%> (-0.95%)`	⬇️
go/arrow/ipc/writer.go
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2746a23...99c0207. Read the comment docs.

pitrou

+1. Thanks @lihalite !

…schemes The motivation is to enable interop with future Flight versions that may support different transports, and to enable a Flight service to reference a non-Flight service. Personal Travis: https://travis-ci.com/lihalite/arrow/builds/120257110 AppVeyor: https://ci.appveyor.com/project/lihalite/arrow/builds/26189055 Closes apache#4928 from lihalite/arrow-6017 and squashes the following commits: 99c0207 <David Li> Enable creating Flight Locations for unknown schemes Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>

Enable creating Flight Locations for unknown schemes

99c0207

jacques-n approved these changes Jul 23, 2019

View reviewed changes

pitrou approved these changes Jul 24, 2019

View reviewed changes

pitrou closed this in c930839 Jul 24, 2019

asfimport mentioned this pull request Aug 1, 2019

[FlightRPC] Allow creating Locations with unknown schemes #22423

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-6017: [FlightRPC] Enable creating Flight Locations for unknown schemes#4928

ARROW-6017: [FlightRPC] Enable creating Flight Locations for unknown schemes#4928
ghost wants to merge 1 commit intomasterfrom
unknown repository

ghost commented Jul 23, 2019

Uh oh!

codecov-io commented Jul 24, 2019

Uh oh!

codecov-io commented Jul 24, 2019

Uh oh!

codecov-io commented Jul 24, 2019 •

edited

Loading

Uh oh!

codecov-io commented Jul 24, 2019 •

edited

Loading

Uh oh!

codecov-io commented Jul 24, 2019 •

edited

Loading

Uh oh!

codecov-io commented Jul 24, 2019 •

edited

Loading

Uh oh!

pitrou left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ghost commented Jul 23, 2019

Uh oh!

codecov-io commented Jul 24, 2019

Codecov Report

Uh oh!

codecov-io commented Jul 24, 2019

Codecov Report

Uh oh!

codecov-io commented Jul 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-io commented Jul 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-io commented Jul 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-io commented Jul 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pitrou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-io commented Jul 24, 2019 •

edited

Loading

codecov-io commented Jul 24, 2019 •

edited

Loading

codecov-io commented Jul 24, 2019 •

edited

Loading

codecov-io commented Jul 24, 2019 •

edited

Loading