GH-39600: [R] Add trademark attribution to pkgdown site footer#49332
GH-39600: [R] Add trademark attribution to pkgdown site footer#49332thisisnic wants to merge 1 commit intoapache:mainfrom
Conversation
Generated-by: Claude
|
@github-actions crossbow submit preview-docs |
|
|
|
Revision: 5e14191 Submitted crossbow builds: ursacomputing/crossbow @ actions-3bc0f1949a
|
jonkeane
left a comment
There was a problem hiding this comment.
I'm not a huge huge fan of the formatting, at a minimum I wish it had a bit more whitespace between the older version bit and the legal text.
I have some suggestions for making it a separate component which might help some, but we maybe nee do <div style="...">...</div> to make this a little more separate from the current footer.
Alternatively: if it were the full length of the screen slightly above the current footer that might make it stand out a little bit less (in a good way)?
| older_versions: | | ||
| [Older versions of these docs](https://arrow.apache.org/docs/r/versions.html) | ||
| <br><small>Apache Arrow, Arrow, Apache, the Apache logo, and the Apache Arrow project logo are either registered trademarks or trademarks of The Apache Software Foundation in the United States and other countries.</small> |
There was a problem hiding this comment.
| older_versions: | | |
| [Older versions of these docs](https://arrow.apache.org/docs/r/versions.html) | |
| <br><small>Apache Arrow, Arrow, Apache, the Apache logo, and the Apache Arrow project logo are either registered trademarks or trademarks of The Apache Software Foundation in the United States and other countries.</small> | |
| older_versions: "[Older versions of these docs](https://arrow.apache.org/docs/r/versions.html)" | |
| legal: | | |
| <small>Apache Arrow, Arrow, Apache, the Apache logo, and the Apache Arrow project logo are either registered trademarks or trademarks of The Apache Software Foundation in the United States and other countries.</small> |
We can have multiple components in the footer
| @@ -365,4 +365,6 @@ footer: | |||
| left: older_versions | |||
| right: built_with | |||
There was a problem hiding this comment.
| right: built_with | |
| right: [built_with, legal] |
Rationale for this change
Per ASF policy, documentation pages should include trademark attribution in the footer. See #39461 for the broader effort.
What changes are included in this PR?
Add Apache trademark attribution text to the R pkgdown site footer.
Are these changes tested?
Documentation only. Can verify by building pkgdown site locally.
Are there any user-facing changes?
Footer now includes trademark text matching the main Arrow website.
This PR was generated by Claude. All outputs were reviewed and confirmed before pushing.