GH-49364: [Ruby] Simplify reader tests#49365
Merged
kou merged 1 commit intoapache:mainfrom Feb 22, 2026
Merged
Conversation
|
|
github-actions
bot
added
Component: Ruby
awaiting committer review
kou
force-pushed
the
ruby-test-reader
branch
from
147c753 to
fa8aaa2
Compare
kou
force-pushed
the
ruby-test-reader
branch
from
fa8aaa2 to
c2a4b3f
Compare
Member
Author
|
+1 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 84a5701. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The current reader tests use a sub test case per type but we can use a test per type like the current writer tests.
What changes are included in this PR?
ArrowFormat::Type#to_sArrowFormat::FileReader#schemaAre these changes tested?
Yes.
Are there any user-facing changes?
No.