Skip to content

GH-49428: [C++][Gandiva] Add support for LLVM 22.1.0#49429

Merged
kou merged 3 commits intoapache:mainfrom
raulcd:GH-49428
Mar 4, 2026
Merged

GH-49428: [C++][Gandiva] Add support for LLVM 22.1.0#49429
kou merged 3 commits intoapache:mainfrom
raulcd:GH-49428

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Mar 2, 2026

Rationale for this change

Some of our CI jobs fail because conda jobs are pulling LLVM 22.1.0 and we are not compatible.

What changes are included in this PR?

Add 22.1.0 as compatible LLVM and minor fix to update the location of PassPlugin.h due to:

Are these changes tested?

Yes via CI

Are there any user-facing changes?

No, the only change is that LLVM 22.1.0 will be supported.

@raulcd
Copy link
Member Author

raulcd commented Mar 2, 2026

@github-actions crossbow submit verify-rc-source-cpp-linux-conda-latest-amd64

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Mar 2, 2026
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Revision: 03d4060

Submitted crossbow builds: ursacomputing/crossbow @ actions-4e898891dc

Task Status
verify-rc-source-cpp-linux-conda-latest-amd64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Mar 3, 2026

@github-actions crossbow submit verify-rc-source-cpp-linux-conda-latest-amd64

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Revision: 7b9135a

Submitted crossbow builds: ursacomputing/crossbow @ actions-0b9f3c458a

Task Status
verify-rc-source-cpp-linux-conda-latest-amd64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Mar 3, 2026

@github-actions crossbow submit verify-rc-source-*

@raulcd raulcd marked this pull request as ready for review March 3, 2026 10:51
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Revision: 7b9135a

Submitted crossbow builds: ursacomputing/crossbow @ actions-33740b985f

Task Status
verify-rc-source-cpp-linux-almalinux-10-amd64 GitHub Actions
verify-rc-source-cpp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-cpp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-cpp-linux-ubuntu-24.04-amd64 GitHub Actions
verify-rc-source-cpp-macos-amd64 GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-cpp-macos-conda-amd64 GitHub Actions
verify-rc-source-integration-linux-almalinux-10-amd64 GitHub Actions
verify-rc-source-integration-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-24.04-amd64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions
verify-rc-source-python-linux-almalinux-10-amd64 GitHub Actions
verify-rc-source-python-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-24.04-amd64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions
verify-rc-source-ruby-linux-almalinux-10-amd64 GitHub Actions
verify-rc-source-ruby-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-24.04-amd64 GitHub Actions
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions
verify-rc-source-windows GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Mar 3, 2026

The C GLib & Ruby failure is unrelated. I've opened an issue and submitted a PR to track it and fix it (#49436)
The Python and C++ macOS failures are known due to AWS cpp being broken on brew.

@raulcd raulcd requested a review from kou March 3, 2026 11:37
@raulcd
Copy link
Member Author

raulcd commented Mar 3, 2026

The verification job failure: verify-rc-source-cpp-macos-conda-amd64 is not related but seems like a bug that has been introduce somewhere. I'll open a separate issue for it once this is merged.

@kou
Copy link
Member

kou commented Mar 4, 2026

@github-actions crossbow submit verify-rc-source-cpp-linux-conda-latest-amd64

@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Revision: c6cacd1

Submitted crossbow builds: ursacomputing/crossbow @ actions-b09d2cf06f

Task Status
verify-rc-source-cpp-linux-conda-latest-amd64 GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit c61df29 into apache:main Mar 4, 2026
46 of 51 checks passed
@kou kou removed the awaiting change review Awaiting change review label Mar 4, 2026
@github-actions github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Mar 4, 2026
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c61df29.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants