Skip to content

GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent#49507

Merged
rok merged 3 commits intoapache:mainfrom
rok:GH-49506
Mar 13, 2026
Merged

GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent#49507
rok merged 3 commits intoapache:mainfrom
rok:GH-49506

Conversation

@rok
Copy link
Member

@rok rok commented Mar 13, 2026

Rationale for this change

See #49506.

What changes are included in this PR?

We skip cuda docstests in CI, since we don't build for CUDA.

Are these changes tested?

We currently see failing CI. That should go away.

Are there any user-facing changes?

Only to CI users.

@rok rok requested review from AlenkaF and raulcd as code owners March 13, 2026 12:16
@rok rok changed the title [CI][Python] Doctest fails when pyarrow._cuda absent GH-49506: [CI][Python] Doctest fails when pyarrow._cuda absent Mar 13, 2026
@apache apache deleted a comment from github-actions bot Mar 13, 2026
@github-actions
Copy link

⚠️ GitHub issue #49506 has been automatically assigned in GitHub to PR creator.

@rok
Copy link
Member Author

rok commented Mar 13, 2026

Crossposting from the issue:

This is likely due to the new release of pytest-cython v0.4.0 that started to be used on runners.

--doctest-cython now collects .pyx files even when binary doesn't exist (see v0.3.0 vs v0.4.0)

@rok
Copy link
Member Author

rok commented Mar 13, 2026

@raulcd - this is to fix the current CI failure. Quick check before I merge?

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor nit, feel free to ignore

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting review Awaiting review and removed awaiting committer review Awaiting committer review labels Mar 13, 2026
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@github-actions github-actions bot added awaiting review Awaiting review and removed awaiting review Awaiting review awaiting merge Awaiting merge labels Mar 13, 2026
@rok
Copy link
Member Author

rok commented Mar 13, 2026

Thanks for review @raulcd, will merge once CI is green.

@rok rok merged commit a315b96 into apache:main Mar 13, 2026
23 of 24 checks passed
@rok rok removed the awaiting review Awaiting review label Mar 13, 2026
@rok rok deleted the GH-49506 branch March 13, 2026 15:23
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a315b96.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants