Skip to content

GH-49738: [R][CI] Re-enable GCC+LTO job once rhub has a GCC 15 image#49795

Merged
thisisnic merged 6 commits intoapache:mainfrom
thisisnic:GH-49738-gcc15-job
May 5, 2026
Merged

GH-49738: [R][CI] Re-enable GCC+LTO job once rhub has a GCC 15 image#49795
thisisnic merged 6 commits intoapache:mainfrom
thisisnic:GH-49738-gcc15-job

Conversation

@thisisnic
Copy link
Copy Markdown
Member

@thisisnic thisisnic commented Apr 18, 2026

Rationale for this change

We removed a job as it was too old and didn't reflect CRAN and now we added it in as we have one which does reflect CRAN's environments

What changes are included in this PR?

Add GCC 15 job

Are these changes tested?

On CI, sure

Are there any user-facing changes?

Nah

@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #49738 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Apr 18, 2026
@jonkeane
Copy link
Copy Markdown
Member

The error

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-dplyr-filter.R:295:5'): Filtering on a column that doesn't exist errors correctly ──
<validation_error/rlang_error/error/condition>
Error in `not_a_col == 42`: object 'not_a_col' not found
Backtrace:
...

is coming from:

expect_warning(
expect_error(
tbl |> record_batch() |> filter(not_a_col == 42) |> collect(),
"objet 'not_a_col' introuvable"
),
NA
)
})

Which makes it seem like there's something up with translations / locale not being quite right in the runner / our setup

@thisisnic
Copy link
Copy Markdown
Member Author

There were changes in #37811 that never got merged as it got complex, which I'll add in here so hopefully those should help

Comment thread r/tests/testthat/test-dplyr-filter.R
@github-actions github-actions Bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Apr 21, 2026
@@ -35,19 +35,25 @@ options(arrow.pull_as_vector = FALSE)

with_language <- function(lang, expr) {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why do we have our own with_language() here? I might try out the withr one before we merge this...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does #37811 (comment) have any info about why we have a separate one?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sort of makes sense.

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 21, 2026
@thisisnic thisisnic force-pushed the GH-49738-gcc15-job branch from 47edb30 to d627671 Compare April 29, 2026 17:35
@github-actions github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 29, 2026
@thisisnic
Copy link
Copy Markdown
Member Author

Any more changes before merging @jonkeane?

Copy link
Copy Markdown
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI is passing, let's merge

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels May 5, 2026
@thisisnic thisisnic merged commit f69ccb0 into apache:main May 5, 2026
26 of 27 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label May 5, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit f69ccb0.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants