GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49802
Closed
Swaroop883 wants to merge 1 commit intoapache:mainfrom
Closed
GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49802Swaroop883 wants to merge 1 commit intoapache:mainfrom
Swaroop883 wants to merge 1 commit intoapache:mainfrom
Conversation
Author
|
Closing this as the fix has already been merged in #49790. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ARROW_DOC_DIRwas hardcoded as"share/doc/${PROJECT_NAME}"which does not respect system-specific documentation directory
conventions. All other install directories in this file already
use
GNUInstallDirsvariables (e.g.CMAKE_INSTALL_DATADIR,CMAKE_INSTALL_LIBDIR). This change makesARROW_DOC_DIRconsistent with that pattern.
What changes are included in this PR?
set(ARROW_DOC_DIR "share/doc/${PROJECT_NAME}")withset(ARROW_DOC_DIR "${CMAKE_INSTALL_DOCDIR}")incpp/CMakeLists.txt.Are these changes tested?
No new tests are needed. This is a build system change that affects
only the install path of documentation files (LICENSE.txt, NOTICE.txt,
README.md). The behavior is identical on standard systems where
CMAKE_INSTALL_DOCDIRdefaults toshare/doc/${PROJECT_NAME}.Are there any user-facing changes?
No. On standard Linux/macOS systems the install path remains
share/doc/arrow. Users who explicitly overrideCMAKE_INSTALL_DOCDIRwill now have their setting respected, which is the correct behavior.
CMAKE_INSTALL_DOCDIRinstead of staticshare/doc/${PROJECT_NAME}#49789