GH-49872: [C++] Remove deprecated std::is_trivial#49871
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
|
|
@pitrou hello! I am believe my contribution did not effect the failed Python CI job. But it seems that C++ Extra workflows was skipped because of that |
|
I think the C++ Extra builds actually ran fine. Two of them were skipped for unrelated reasons. And you're right that the macOS Python build failure looks unrelated. |
Resolves #49872
Rationale for this change
std::is_trivialis deprecated since C++26, so it leads to warning when building app with Apache Arrow and new C++ standardWhat changes are included in this PR?
This PR applies suggestion from libc++ code:
'is_trivial<std::shared_ptr<arrow::io::ReadableFile>>' is deprecated: Consider using is_trivially_copyable<T>::value && is_trivially_default_constructible<T>::value insteadAre these changes tested?
Tested with CI
Are there any user-facing changes?
Changes allow user to build with warning as error flags