MINOR: [R] Skip translation tests if NLS is not enabled#49874
Merged
jonkeane merged 1 commit intoapache:mainfrom Apr 27, 2026
Merged
MINOR: [R] Skip translation tests if NLS is not enabled#49874jonkeane merged 1 commit intoapache:mainfrom
jonkeane merged 1 commit intoapache:mainfrom
Conversation
jonkeane
approved these changes
Apr 27, 2026
Member
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Thanks for this. This should be just fine to merge regardless, but do you happen to have a way that you test this in CI? I would be totally fine to add --disable-nls somewhere in our matrix, though ideally we won't need to build R from source just for that. Do you have any CI that does that?
github-actions
Bot
added
awaiting merge
Contributor
Author
|
Don't have one handy, I'd bet re-building R (needed for |
Member
|
Agreed, building R from source is overkill. Let's merge this as is — I don't think it needs anything else (or a news entry, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
R builds with
--disable-nlsand no-DENABLE_NLS=1will not translate any messages, so associated tests don't really make sense.What changes are included in this PR?
Skip such tests by reading from
capabilities().Are these changes tested?
GHA/CI
Are there any user-facing changes?
No
Could this be solved another way?
Yes, I think we could just use
withr::with_language()instead which has its owncapabilities()check:https://github.com/r-lib/withr/blob/22e392c9cc13efaa9ba042bb193991f78316edb1/R/language.R#L81