GH-49981: [R][Packaging] Support building R package under r-universe/r-wasm#49982
Conversation
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: 18fe759 Submitted crossbow builds: ursacomputing/crossbow @ actions-8ee2d3b170
|
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: a2fa12a Submitted crossbow builds: ursacomputing/crossbow @ actions-4178688350
|
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: 5ee8457 Submitted crossbow builds: ursacomputing/crossbow @ actions-3963128ccf
|
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: 5ee8457 Submitted crossbow builds: ursacomputing/crossbow @ actions-8c87567db5
|
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: b37e9d0 Submitted crossbow builds: ursacomputing/crossbow @ actions-0aa60bce30
|
jonkeane
left a comment
There was a problem hiding this comment.
Thanks for this! One comment about naming and then mostly questions for my understanding. This is exciting to see working!
|
@github-actions crossbow submit test-r-wasm |
|
Revision: 7eb72ac Submitted crossbow builds: ursacomputing/crossbow @ actions-df03aafab4
|
|
Merged, thanks for the review. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 876d50c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Arrow C++ already supports Emscripten but the R package can't be built by either the r-wasm or r-universe projects in its current state. We just need to make the bundled build Emscripten aware we're in an Emscripten environment for this to work.
What changes are included in this PR?
build_arrow_static.shEmscripten-aware by adding support for being called with a wrapper programAre these changes tested?
Yes. The R package builds in a local docker r-wasm-based container as well as in Crossbow
Are there any user-facing changes?
No.