GH-50010: [C++][Parquet] Fix undefined behavior in TypedColumnWriterImpl::UpdateLevelHistogram#50011
Merged
Merged
Conversation
|
|
github-actions
Bot
added
awaiting committer review
Contributor
Author
|
@pitrou Please take a look. |
Member
|
This is a trivial fix. Will merge it tomorrow if no objection. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3589dc2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…riterImpl::UpdateLevelHistogram (apache#50011) ### Rationale for this change Fix an undefined behavior. ### What changes are included in this PR? It fixes the undefined behavior by delaying the span construction. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#50010 Authored-by: Zehua Zou <zehuazou2000@gmail.com> Signed-off-by: Gang Wu <ustcwg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix an undefined behavior.
What changes are included in this PR?
It fixes the undefined behavior by delaying the span construction.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
TypedColumnWriterImpl::UpdateLevelHistogram#50010