GH-33420: [R] Improve error message when providing a mix of readr and Arrow options#50048
Open
Rich-T-kid wants to merge 2 commits into
Open
GH-33420: [R] Improve error message when providing a mix of readr and Arrow options#50048Rich-T-kid wants to merge 2 commits into
Rich-T-kid wants to merge 2 commits into
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
Author
|
@thisisnic could you take a look at this? 🫡 thx |
Member
|
Thanks for the PR @Rich-T-kid! Looks pretty good, just a couple of suggested changes from me:
Give me a shout if you have any question! |
Author
|
@thisisnic pushed a PR that updates a test. Could you take another look 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
closes #33420
What changes are included in this PR?
updates the error message returned
Are these changes tested?
No, minimal change so I don't think its needed
Are there any user-facing changes?
better error responses for users.