Skip to content

GH-47100: [Docs] Correct the Statistics schema specification#50092

Merged
thisisnic merged 1 commit into
apache:mainfrom
thisisnic:GH-47100
Jun 4, 2026
Merged

GH-47100: [Docs] Correct the Statistics schema specification#50092
thisisnic merged 1 commit into
apache:mainfrom
thisisnic:GH-47100

Conversation

@thisisnic
Copy link
Copy Markdown
Member

@thisisnic thisisnic commented Jun 4, 2026

Rationale for this change

Docs were incorrect apparently

What changes are included in this PR?

Update them

Are these changes tested?

Nope

Are there any user-facing changes?

No

Copilot AI review requested due to automatic review settings June 4, 2026 08:45
@thisisnic thisisnic requested a review from kou June 4, 2026 08:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

⚠️ GitHub issue #47100 has been automatically assigned in GitHub to PR creator.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the Arrow Statistics schema specification documentation to remove references to “table” as a statistics target, aligning the spec text with the intended scope (record batches / arrays) described in issue #47100.

Changes:

  • Clarified that column = null indicates statistics for the whole record batch or array (not a table).
  • Updated multiple sentences to state statistics can apply to a column, record batch, or array (removing “table”).
  • Updated ARROW:row_count:{exact,approximate} descriptions to refer to record batch or array only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kou kou changed the title GH-47100: [Specification][Statistics] Correct the Statistics schema specification GH-47100: [Docs] Correct the Statistics schema specification Jun 4, 2026
Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 4, 2026
@thisisnic thisisnic merged commit 3c9cb0c into apache:main Jun 4, 2026
13 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Jun 4, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 3c9cb0c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants