Skip to content

GH-50098: [C++][Parquet] Enable filesystem support when building Parquet utilities#50099

Merged
kou merged 1 commit into
apache:mainfrom
pitrou:gh50098-parquet-cli-tools-filesystem
Jun 4, 2026
Merged

GH-50098: [C++][Parquet] Enable filesystem support when building Parquet utilities#50099
kou merged 1 commit into
apache:mainfrom
pitrou:gh50098-parquet-cli-tools-filesystem

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Jun 4, 2026

Rationale for this change

Some Parquet utilities call the Arrow filesystem API.

Also make sure that compute benchmarks are not built when the full compute kernels registry is not enabled.

Are these changes tested?

Manually.

Are there any user-facing changes?

No.

set_option_category("Parquet")

define_option(PARQUET_BUILD_EXECUTABLES
"Build the Parquet executable CLI tools. Requires static libraries to be built."
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that static libraries are not required for the Parquet executables to work, so removing the misleading statement.

@pitrou pitrou marked this pull request as ready for review June 4, 2026 13:34
@pitrou pitrou requested a review from kou June 4, 2026 13:34
@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 4, 2026
Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 2315161 into apache:main Jun 4, 2026
58 of 60 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Jun 4, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants