GH-50222: [C++] Use FetchContent for xsimd#50303
Open
AntoinePrv wants to merge 1 commit into
Open
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Arrow C++’s third-party toolchain to vendor xsimd via CMake FetchContent, addressing cases where Arrow itself is consumed via FetchContent and xsimd headers need to be available during configuration.
Changes:
- Replaces the previous
ExternalProject_Add()-based xsimd build withFetchContent(fetchcontent_declare/fetchcontent_makeavailable). - Introduces an
arrow::xsimdimported INTERFACE target that points at the fetched source include directory. - Converts
build_xsimdfrom a macro to a function and propagates key variables to the parent scope.
AntoinePrv
force-pushed
the
fetchcontent-xsimd
branch
from
d2a08ea to
fd44d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
FetchContent suggested as better approach in GH-45303.
What changes are included in this PR?
Use FetchContent for xsimd and solve a bug where xsimd is not available at configure time.
Are these changes tested?
Yes, locally.
Are there any user-facing changes?
No.