Skip to content

GH-50330: [C++][R][Parquet] Add missing typename in RleBitPackedDecoderGetRunDecode#50332

Merged
raulcd merged 1 commit into
apache:mainfrom
AntoinePrv:bu-rle-typename
Jul 2, 2026
Merged

GH-50330: [C++][R][Parquet] Add missing typename in RleBitPackedDecoderGetRunDecode#50332
raulcd merged 1 commit into
apache:mainfrom
AntoinePrv:bu-rle-typename

Conversation

@AntoinePrv

@AntoinePrv AntoinePrv commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Rationale for this change

Fix compiler error.

What changes are included in this PR?

Missing typename keyword.

Are these changes tested?

In CI.

Are there any user-facing changes?

No.

@AntoinePrv AntoinePrv requested a review from pitrou as a code owner July 2, 2026 08:35
Copilot AI review requested due to automatic review settings July 2, 2026 08:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a C++ compiler error affecting the R/Linux-as-CRAN build by adding the required typename keyword before a dependent nested type in RleBitPackedDecoder’s run-decoder alias.

Changes:

  • Add typename to RleBitPackedDecoderGetRunDecoder<...>::type in GetBatch.
  • Add typename to the same alias in GetSpaced.
  • Add typename to the same alias in GetBatchWithDict.

@kou

kou commented Jul 2, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-r-linux-as-cran

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Revision: 6dfe1be

Submitted crossbow builds: ursacomputing/crossbow @ actions-31f8755bf3

Task Status
test-r-linux-as-cran GitHub Actions

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, job is green now :)

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jul 2, 2026
@raulcd raulcd merged commit 0f6dd60 into apache:main Jul 2, 2026
67 of 68 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Jul 2, 2026
raulcd pushed a commit that referenced this pull request Jul 2, 2026
…erGetRunDecode (#50332)

### Rationale for this change
Fix compiler error.

### What changes are included in this PR?
Missing typename keyword.

### Are these changes tested?
In CI.

### Are there any user-facing changes?
No.

* GitHub Issue: #50330

Authored-by: AntoinePrv <AntoinePrv@users.noreply.github.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@AntoinePrv AntoinePrv deleted the bu-rle-typename branch July 2, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants