Skip to content

ARROW-6269: [C++] check decimal precision in IPC code#5104

Closed
crepererum wants to merge 1 commit intoapache:masterfrom
crepererum:ARROW-6269
Closed

ARROW-6269: [C++] check decimal precision in IPC code#5104
crepererum wants to merge 1 commit intoapache:masterfrom
crepererum:ARROW-6269

Conversation

@crepererum
Copy link
Copy Markdown
Contributor

No description provided.

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Sep 2, 2019

Rebased and improved.

Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, will wait for CI.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5104 into master will increase coverage by 1.85%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5104      +/-   ##
==========================================
+ Coverage   87.35%    89.2%   +1.85%     
==========================================
  Files         920      750     -170     
  Lines      124475   107890   -16585     
  Branches     1437        0    -1437     
==========================================
- Hits       108730    96244   -12486     
+ Misses      15383    11646    -3737     
+ Partials      362        0     -362
Impacted Files Coverage Δ
cpp/src/arrow/type.h 92.52% <ø> (ø) ⬆️
cpp/src/arrow/ipc/metadata_internal.cc 87.97% <100%> (+4.59%) ⬆️
cpp/src/arrow/type.cc 93.91% <87.5%> (+0.04%) ⬆️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
... and 464 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c42e6f...3de8c0c. Read the comment docs.

@crepererum
Copy link
Copy Markdown
Contributor Author

Sorry, I was busy since submitting this PR. Thanks @pitrou, looks really good now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants