ARROW-6284: [C++] Allow references in std::tuple when converting tuple to arrow array#5112
Closed
ozars wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-6284: [C++] Allow references in std::tuple when converting tuple to arrow array#5112ozars wants to merge 3 commits intoapache:masterfrom
ozars wants to merge 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5112 +/- ##
==========================================
+ Coverage 87.64% 89.22% +1.58%
==========================================
Files 1014 731 -283
Lines 145922 104999 -40923
Branches 1437 0 -1437
==========================================
- Hits 127887 93690 -34197
+ Misses 17673 11309 -6364
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
std::vector<std::tuple>can be converted to a table by treating each tuple as a row and by building arrays corresponding to each element of the tuple. This PR allows reference types (and const reference types) in elements ofstd::tuplewhich is to be converted. This is useful for converting user defined types. For example a vector ofCustomType:can be converted to a table like this:
This makes it easier to convert user defined types to arrow tables.