Skip to content

ARROW-795: [C++] Consolidate arrow/arrow_io/arrow_ipc into a single shared and static library#516

Closed
wesm wants to merge 2 commits intoapache:masterfrom
wesm:ARROW-795
Closed

ARROW-795: [C++] Consolidate arrow/arrow_io/arrow_ipc into a single shared and static library#516
wesm wants to merge 2 commits intoapache:masterfrom
wesm:ARROW-795

Conversation

@wesm
Copy link
Copy Markdown
Member

@wesm wesm commented Apr 9, 2017

This leaves c_glib in a broken state, since I'd rather let @kou fix up things the way he prefers (I started refactoring the automake files and realized I would probably just make a mess).

I'm going to submit a patch to make parquet-cpp work on top of this.

…library

Change-Id: Icdc7d231f59aceaa49f5699ea0cb4acb720590fa
@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 9, 2017

@kou if you base changes for arrow-glib on top of this branch, can you post a git commit here for me to cherry pick into this PR, so that we can get a passing build? I can try my hand at cleaning things up if you like, too, but I wasn't sure about some of the generated code in arrow-glib/Makefile.am. Thanks!

@kou
Copy link
Copy Markdown
Member

kou commented Apr 10, 2017

Change-Id: Iac1c3cdce7d94fd2f49472bc511484d5e223f852
@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 10, 2017

Thank you! I just applied the patch

@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 10, 2017

The test suite passed except for Parquet failures / S3 timeouts

@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 10, 2017

@pcmoritz @robertnishihara -- does this seem OK? The idea was to make Arrow simpler to develop against for thirdparties (and easier for us to package / develop internally). The public APIs still have the io:: and ipc:: C++ namespaces

@wesm
Copy link
Copy Markdown
Member Author

wesm commented Apr 10, 2017

+1, @xhochy is on vacation and we spoke briefly about this offline, so I'm going to merge. If there's any unforeseen consequences I'll be responsive to make quick fixes

@asfgit asfgit closed this in d1a9aff Apr 10, 2017
@wesm wesm deleted the ARROW-795 branch April 10, 2017 13:23
@robertnishihara
Copy link
Copy Markdown
Contributor

This makes sense! I don't anticipate any problems here.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
This PR migrates the Arrow project to publish Build Scans to the the new
Develocity instance at develocity.apache.org.

Additionally, this PR sets a projectId for use by Develocity.

Fixes apache#515.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants