ARROW-782: [C++] API cleanup, change public member access in DataType classes to functions, use class instead of struct#520
Closed
wesm wants to merge 5 commits intoapache:masterfrom
Closed
ARROW-782: [C++] API cleanup, change public member access in DataType classes to functions, use class instead of struct#520wesm wants to merge 5 commits intoapache:masterfrom
wesm wants to merge 5 commits intoapache:masterfrom
Conversation
…ss instead of struct Change-Id: Id0551429b786c747af898ddb72ba03bfbd6fc91b
Change-Id: Id19bcd2190215c9950abc99b29a47d3e729ca747
Change-Id: Iaf48f56c361fd4a14b4a4964f15c4276f8a8f634
Member
Author
|
@kou I changed |
Member
|
I think that it may cause GC related crash in bindings. But I'm not sure without trying it. So it's OK the change. If the change has a problem, I just revert the change. |
Member
Author
|
Ok, the problem now is that the |
Change-Id: I8fd7b3123e9b85a1cabccb0913e36ec99acd5cdb
Member
Author
|
+1 |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Fixes apacheGH-520. The configuration file is borrowed from apache/arrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking APIs isn't ideal, but this one is fairly long overdue. The DataType classes are more than passive data carriers, and Google's C++ guide recommends using class instead of struct for this. That means we should put members in protected or private scope, and access them.
I also renamed a couple of things to help with code clarity
DataType::typeis nowDataType::id()Array::type_enumis notArray::type_id