Skip to content

ARROW-6392: [FlightRPC][Python] check type of list_flights result#5242

Closed
ghost wants to merge 2 commits intomasterfrom
unknown repository
Closed

ARROW-6392: [FlightRPC][Python] check type of list_flights result#5242
ghost wants to merge 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 30, 2019

No description provided.

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 30, 2019

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 31, 2019

Codecov Report

Merging #5242 into master will increase coverage by 1.57%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5242      +/-   ##
==========================================
+ Coverage   87.63%    89.2%   +1.57%     
==========================================
  Files        1033      750     -283     
  Lines      148630   107773   -40857     
  Branches     1437        0    -1437     
==========================================
- Hits       130249    96142   -34107     
+ Misses      18019    11631    -6388     
+ Partials      362        0     -362
Impacted Files Coverage Δ
python/pyarrow/_flight.pyx 54.65% <0%> (+1.23%) ⬆️
cpp/src/arrow/python/flight.cc 96.77% <100%> (+3.91%) ⬆️
python/pyarrow/tests/test_flight.py 70.92% <77.77%> (+0.25%) ⬆️
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
... and 280 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2164e3b...4ca820d. Read the comment docs.

@wesm
Copy link
Copy Markdown
Member

wesm commented Aug 31, 2019

Rebased. The Status from get_schema wasn't being checked (causing my clang build to fail) so fixed that

Copy link
Copy Markdown
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants