ARROW-6424: [C++] Fix IPC fuzzing test name#5261
Closed
pitrou wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-6424: [C++] Fix IPC fuzzing test name#5261pitrou wants to merge 1 commit intoapache:masterfrom
pitrou wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@crepererum Can you check this fixes the issue for you? |
crepererum
requested changes
Sep 3, 2019
|
|
||
| class S3Environment : public ::testing::Environment { | ||
| public: | ||
| virtual ~S3Environment() {} |
Contributor
There was a problem hiding this comment.
I think that change is unrelated?
Member
Author
There was a problem hiding this comment.
It is, but i had to make it to compile with clang.
Contributor
There was a problem hiding this comment.
Ah yes, we should probably include this then either here or in another PR.
|
|
||
| get_filename_component(FUZZING_NAME ${REL_FUZZING_NAME} NAME_WE) | ||
|
|
||
| # Make sure the executable name contains only hyphens, not underscores |
Contributor
There was a problem hiding this comment.
that also does the job, thanks!
crepererum
approved these changes
Sep 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #5261 +/- ##
==========================================
+ Coverage 87.35% 89.2% +1.85%
==========================================
Files 920 750 -170
Lines 124479 108000 -16479
Branches 1437 0 -1437
==========================================
- Hits 108738 96342 -12396
+ Misses 15379 11658 -3721
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.