ARROW-6478: [C++] Revert to jemalloc stable-4 until we understand 5.2.x performance issues#5297
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-6478: [C++] Revert to jemalloc stable-4 until we understand 5.2.x performance issues#5297wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
wesm
commented
Sep 6, 2019
Member
Author
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1. I will follow up with the jemalloc folks to do some profiling when I have some time
wesm
changed the title
xhochy
reviewed
Sep 6, 2019
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
Being in mobile: does this also reintroduce vendoring in e.g. the conda package? (It should)
+1 from me for the change in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose we revert to the jemalloc 4.x stable branch where we were before until we understand how to get the performance we need for our workloads from 5.x. See upstream issue jemalloc/jemalloc#1621