ARROW-5562: [C++][Parquet] Write negative zero or small epsilons as positive zero when computing Parquet statistics#5375
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-5562: [C++][Parquet] Write negative zero or small epsilons as positive zero when computing Parquet statistics#5375wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
Member
|
travis failure is https://issues.apache.org/jira/browse/ARROW-6509 |
Member
Author
|
@majetideepak if you have a chance to look at this since it affects Parquet statistics please let us know if you have concerns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OP reported a bug where we could have the "max" statistic equal to
-0.0while the min is+0.0, which causes an error in some processing frameworks like Hive.I also added logic to zero out small epsilons. If this offends anyone, can you suggest an alternative approach to fixing this?