ARROW-6785: [JS] Remove superfluous child assignment#5394
Closed
akre54 wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-6785: [JS] Remove superfluous child assignment#5394akre54 wants to merge 2 commits intoapache:masterfrom
akre54 wants to merge 2 commits intoapache:masterfrom
Conversation
TypeScript's data modifiers [automatically create a `this.children = children` assignment](http://www.typescriptlang.org/play/#code/KYDwDg9gTgLgBAYwDYEMDOa4GUZQK4IwA8AKnKDMAHYAmmA3nANoDWwAngFxxq4CWVAOYBdbgBEUMFCXZhgcAL5wAvHBRV2APnIhKtTBKky5pWcAB0OfIQA0cEtvoAoOK8QQqvazGgAKMHgARkh8CHBQwCg0HkjsiAAWfEg0EVTcAGJ8wMmkrBwQAGb2wppMwgCUcM5uNTx4clC+5QDcLrWuMIlo5giJyakqCUkp1K01Cm2uAcGhcILA8DBmAJI0TVXhC3hQVPZmlrgE8Oh7cgfezYqTcNMhYT5WAoLrjBEw27sABlZHRPQAJPROnxur1hqlzABbFBgXy+AqVZTaT6AgrmKgoSHABScVHmJZyBSfcrmABWEAEvk+dmJCgUmk+lwmNTAUAglEIwBoPCkMFmTCw7EhgQgSHxEEeQhIKBEgzhrPZEG4P0IiMc1xqviI6i0NzZPhJYP61EGVDwSCQY3am3eOz1ioFQpFYoe-ClMuEgwA5CqYF6ra4FOVfL7zAqfATgC0nAogA). I suggest matching the other code and just removing the modifier instead of removing the assignment.
Contributor
|
There's a lint error. I also added a js reviewer :) |
trxcllnt
requested changes
Oct 2, 2019
Contributor
trxcllnt
left a comment
trxcllnt
left a comment
There was a problem hiding this comment.
Good catch, I think this was a copy-paste oversight when I had to reimplement the Map. Other than lint error LGTM 👍
Co-Authored-By: Paul Taylor <paul.e.taylor@me.com>
trxcllnt
approved these changes
Oct 2, 2019
wesm
changed the title
kszucs
pushed a commit
that referenced
this pull request
Oct 5, 2019
From `type.mjs`:  TypeScript's data modifiers [automatically create a `this.children = children` assignment](http://www.typescriptlang.org/play/#code/KYDwDg9gTgLgBAYwDYEMDOa4GUZQK4IwA8AKnKDMAHYAmmA3nANoDWwAngFxxq4CWVAOYBdbgBEUMFCXZhgcAL5wAvHBRV2APnIhKtTBKky5pWcAB0OfIQA0cEtvoAoOK8QQqvazGgAKMHgARkh8CHBQwCg0HkjsiAAWfEg0EVTcAGJ8wMmkrBwQAGb2wppMwgCUcM5uNTx4clC+5QDcLrWuMIlo5giJyakqCUkp1K01Cm2uAcGhcILA8DBmAJI0TVXhC3hQVPZmlrgE8Oh7cgfezYqTcNMhYT5WAoLrjBEw27sABlZHRPQAJPROnxur1hqlzABbFBgXy+AqVZTaT6AgrmKgoSHABScVHmJZyBSfcrmABWEAEvk+dmJCgUmk+lwmNTAUAglEIwBoPCkMFmTCw7EhgQgSHxEEeQhIKBEgzhrPZEG4P0IiMc1xqviI6i0NzZPhJYP61EGVDwSCQY3am3eOz1ioFQpFYoe-ClMuEgwA5CqYF6ra4FOVfL7zAqfATgC0nAogA). I suggest matching the other code and just removing the modifier instead of removing the assignment. Closes #5394 from akre54/patch-1 and squashes the following commits: ea97eba <Adam Krebs> Update js/src/type.ts 32a126e <Adam Krebs> Remove superfluous child assignment Authored-by: Adam Krebs <akre54@users.noreply.github.com> Signed-off-by: Wes McKinney <wesm+git@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From
type.mjs:TypeScript's data modifiers automatically create a
this.children = childrenassignment.I suggest matching the other code and just removing the modifier instead of removing the assignment.