ARROW-6597: [Python] Sanitize Python datetime handling#5416
Closed
pitrou wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-6597: [Python] Sanitize Python datetime handling#5416pitrou wants to merge 1 commit intoapache:masterfrom
pitrou wants to merge 1 commit intoapache:masterfrom
Conversation
The official datetime C macros (PyDate*) operate on a static variable named PyDateTimeAPI. This forces us to initialize that static variable using PyDateTime_IMPORT in every datetime-using C++ module. Fix the issue by redefining PyDateTimeAPI to a global variable. Fixes a crash I got locally in test_pandas.py.
Member
|
This was bothering me, but wasn't sure how to fix it, looks much better now. |
kszucs
approved these changes
Sep 18, 2019
Member
Author
|
Travis-CI passed: https://travis-ci.org/pitrou/arrow/builds/586472251 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official datetime C macros (PyDate*) operate on a static variable
named PyDateTimeAPI. This forces us to initialize that static variable
using PyDateTime_IMPORT in every datetime-using C++ module. Fix the
issue by redefining PyDateTimeAPI to a global variable.
Fixes a crash I got locally in test_pandas.py.