Skip to content

ARROW-6605: [C++][Filesystem] Add recursion depth control to fs::Selector#5429

Closed
fsaintjacques wants to merge 1 commit intoapache:masterfrom
fsaintjacques:ARROW-6605-selector-recursion-depth
Closed

ARROW-6605: [C++][Filesystem] Add recursion depth control to fs::Selector#5429
fsaintjacques wants to merge 1 commit intoapache:masterfrom
fsaintjacques:ARROW-6605-selector-recursion-depth

Conversation

@fsaintjacques
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

@wesm wesm changed the title ARROW-6605: [C++] Add recursion depth control to fs::Selector ARROW-6605: [C++][Filesystem] Add recursion depth control to fs::Selector Sep 19, 2019
@fsaintjacques fsaintjacques force-pushed the ARROW-6605-selector-recursion-depth branch from ca4e7e7 to 08e8b48 Compare September 20, 2019 13:49
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5429 into master will increase coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5429      +/-   ##
==========================================
+ Coverage   88.62%   89.18%   +0.56%     
==========================================
  Files         958      766     -192     
  Lines      127400   111998   -15402     
  Branches     1495        0    -1495     
==========================================
- Hits       112912    99890   -13022     
+ Misses      14123    12108    -2015     
+ Partials      365        0     -365
Impacted Files Coverage Δ
cpp/src/arrow/filesystem/test_util.h 100% <ø> (ø) ⬆️
cpp/src/arrow/filesystem/s3fs.cc 88.67% <100%> (+0.01%) ⬆️
cpp/src/arrow/filesystem/mockfs.cc 94.64% <100%> (ø) ⬆️
cpp/src/arrow/filesystem/localfs.cc 95.68% <100%> (+0.03%) ⬆️
cpp/src/arrow/filesystem/filesystem.cc 85% <100%> (+4.49%) ⬆️
cpp/src/arrow/filesystem/filesystem.h 100% <100%> (ø) ⬆️
cpp/src/arrow/filesystem/test_util.cc 99.48% <100%> (+0.06%) ⬆️
cpp/src/arrow/filesystem/s3_internal.h 90.74% <0%> (-3.71%) ⬇️
cpp/src/arrow/csv/column_builder.cc 95.54% <0%> (-1.49%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19ee70...08e8b48. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants