ARROW-6767: [JS] Lazily bind batches in scan/scanReverse#5565
Closed
rolyatmax wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-6767: [JS] Lazily bind batches in scan/scanReverse#5565rolyatmax wants to merge 1 commit intoapache:masterfrom
rolyatmax wants to merge 1 commit intoapache:masterfrom
Conversation
trxcllnt
approved these changes
Oct 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #5565 +/- ##
==========================================
+ Coverage 88.58% 89.6% +1.01%
==========================================
Files 967 102 -865
Lines 128766 6636 -122130
Branches 1501 1501
==========================================
- Hits 114066 5946 -108120
+ Misses 14335 679 -13656
+ Partials 365 11 -354Continue to review full report at Codecov.
|
Member
|
Thanks @rolyatmax! |
kszucs
pushed a commit
that referenced
this pull request
Oct 5, 2019
I noticed some `TODO` comments in the JS client library that expressed interest in calling `bind(batch)` lazily. This PR implements that optimization and updates related tests. Happy to make updates per feedback! Created a JIRA issue [here](https://issues.apache.org/jira/browse/ARROW-6767). Closes #5565 from rolyatmax/tb/lazily-bind-batches and squashes the following commits: 8877a8f <Taylor Baldwin> ARROW-6767: lazily bind batches in scan/scanReverse Authored-by: Taylor Baldwin <tbaldwin@uber.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some
TODOcomments in the JS client library that expressed interest in callingbind(batch)lazily. This PR implements that optimization and updates related tests.Happy to make updates per feedback!
Created a JIRA issue here.