ARROW-839: [Python] Use mktime variant that is reliable on MSVC#559
Closed
wesm wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-839: [Python] Use mktime variant that is reliable on MSVC#559wesm wants to merge 3 commits intoapache:masterfrom
wesm wants to merge 3 commits intoapache:masterfrom
Conversation
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
This also reverts an unintentional regression from apache#544 when code from config.h was moved to platform.h Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#559 from wesm/ARROW-839 and squashes the following commits: 2e9b300 [Wes McKinney] Use _mkgmtime64 on MSVC f182bab [Wes McKinney] Restore include order in platform.h 38c29bf [Wes McKinney] Add Windows build instructions for Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also reverts an unintentional regression from #544 when code from config.h was moved to platform.h