ARROW-6852: [C++] Fix build issue on memory-benchmark#5624
Closed
guyuqi wants to merge 1 commit into
Closed
Conversation
After the new commit: ARROW-6381 was merged in master, build would fail on Arm64 when DARROW_BUILD_BENCHMARKS is enabled. Change-Id: Ie39c2df08c93c9993b4c2ad9cd11f1f37f714b95 Signed-off-by: Yuqi Gu <yuqi.gu@arm.com>
Codecov Report
@@ Coverage Diff @@
## master #5624 +/- ##
==========================================
+ Coverage 88.91% 89.47% +0.55%
==========================================
Files 985 793 -192
Lines 133539 118029 -15510
Branches 1501 0 -1501
==========================================
- Hits 118739 105602 -13137
+ Misses 14435 12427 -2008
+ Partials 365 0 -365
Continue to review full report at Codecov.
|
Member
|
Thanks @guyuqi for the fix! |
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 21, 2019
After the new commit: ARROW-6381 was merged in master, build would fail on Arm64 when DARROW_BUILD_BENCHMARKS is enabled. Closes apache#5624 from guyuqi/build-failed-membench and squashes the following commits: ed94e1f <Yuqi Gu> ARROW-6852: Fix build issue on memory-benchmark Authored-by: Yuqi Gu <yuqi.gu@arm.com> Signed-off-by: Antoine Pitrou <pitrou@free.fr>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 21, 2019
After the new commit: ARROW-6381 was merged in master, build would fail on Arm64 when DARROW_BUILD_BENCHMARKS is enabled. Closes apache#5624 from guyuqi/build-failed-membench and squashes the following commits: ed94e1f <Yuqi Gu> ARROW-6852: Fix build issue on memory-benchmark Authored-by: Yuqi Gu <yuqi.gu@arm.com> Signed-off-by: Antoine Pitrou <pitrou@free.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the new commit: ARROW-6381 was merged in master,
build would fail on Arm64 when DARROW_BUILD_BENCHMARKS is enabled.