ARROW-6864: [C++] Add compression-related compile definitions before adding any unit tests#5635
Closed
wesm wants to merge 1 commit into
Closed
ARROW-6864: [C++] Add compression-related compile definitions before adding any unit tests#5635wesm wants to merge 1 commit into
wesm wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5635 +/- ##
==========================================
+ Coverage 88.91% 89.48% +0.56%
==========================================
Files 988 796 -192
Lines 134220 118714 -15506
Branches 1501 0 -1501
==========================================
- Hits 119348 106236 -13112
+ Misses 14507 12478 -2029
+ Partials 365 0 -365
Continue to review full report at Codecov.
|
bkietz
approved these changes
Oct 13, 2019
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 21, 2019
…adding any unit tests Apparently when `add_definitions` is called it does not necessarily affect executables that have already been added. Closes apache#5635 from wesm/ARROW-6864 and squashes the following commits: 76b68d3 <Wes McKinney> Add compression-related compile definitions before adding any unit tests Authored-by: Wes McKinney <wesm+git@apache.org> Signed-off-by: Wes McKinney <wesm+git@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently when
add_definitionsis called it does not necessarily affect executables that have already been added.