ARROW-6882: [C++] Ensure the DictionaryArray indices has no dictionary data#5656
Closed
jorisvandenbossche wants to merge 1 commit into
Closed
Conversation
pitrou
approved these changes
Oct 14, 2019
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1. Thank you @jorisvandenbossche !
Codecov Report
@@ Coverage Diff @@
## master #5656 +/- ##
=========================================
Coverage ? 89.49%
=========================================
Files ? 796
Lines ? 118752
Branches ? 0
=========================================
Hits ? 106283
Misses ? 12469
Partials ? 0
Continue to review full report at Codecov.
|
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 21, 2019
…y data Closes apache#5656 from jorisvandenbossche/ARROW-6882-dictionary-indices-validate and squashes the following commits: b4993eb <Joris Van den Bossche> ARROW-6882: Ensure the DictionaryArray indices has no dictionary data Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <pitrou@free.fr>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 21, 2019
…y data Closes apache#5656 from jorisvandenbossche/ARROW-6882-dictionary-indices-validate and squashes the following commits: b4993eb <Joris Van den Bossche> ARROW-6882: Ensure the DictionaryArray indices has no dictionary data Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <pitrou@free.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.