Skip to content

ARROW-6913: [R] Potential bug in compute.cc#5682

Closed
nealrichardson wants to merge 1 commit intoapache:masterfrom
nealrichardson:and-and
Closed

ARROW-6913: [R] Potential bug in compute.cc#5682
nealrichardson wants to merge 1 commit intoapache:masterfrom
nealrichardson:and-and

Conversation

@nealrichardson
Copy link
Copy Markdown
Member

No description provided.

@nealrichardson nealrichardson requested a review from pitrou October 17, 2019 14:07
Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@github-actions
Copy link
Copy Markdown

@wesm
Copy link
Copy Markdown
Member

wesm commented Oct 17, 2019

I guess this bug wasn't hit by any unit test?

@nealrichardson
Copy link
Copy Markdown
Member Author

The code is definitely covered by tests, but I guess nothing triggered the condition where it would do the unexpected thing.

@pitrou pitrou closed this in 6f2c904 Oct 17, 2019
@pitrou
Copy link
Copy Markdown
Member

pitrou commented Oct 17, 2019

Thank you @nealrichardson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants