Skip to content

ARROW-6961: [C++][Gandiva] Add string lower function in Gandiva#5712

Closed
pprudhvi wants to merge 3 commits intoapache:masterfrom
pprudhvi:lower
Closed

ARROW-6961: [C++][Gandiva] Add string lower function in Gandiva#5712
pprudhvi wants to merge 3 commits intoapache:masterfrom
pprudhvi:lower

Conversation

@pprudhvi
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

@pprudhvi pprudhvi closed this Oct 23, 2019
@pprudhvi pprudhvi reopened this Oct 23, 2019
@pprudhvi pprudhvi closed this Oct 23, 2019
@pprudhvi pprudhvi reopened this Oct 23, 2019
Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single comment.

Comment thread cpp/src/gandiva/precompiled/string_ops.cc
@pprudhvi pprudhvi closed this Oct 23, 2019
@pprudhvi pprudhvi reopened this Oct 23, 2019
@pprudhvi
Copy link
Copy Markdown
Contributor Author

@pitrou some builds are failing. I retriggered a couple of times by closing and reopening, each time different builds are breaking. All builds succeeded across all runs but not in any single run, Could you please merge this?

@pprudhvi pprudhvi closed this Oct 24, 2019
@pprudhvi pprudhvi reopened this Oct 24, 2019
@pitrou
Copy link
Copy Markdown
Member

pitrou commented Oct 24, 2019

@pprudhvi I'll do as soon as Travis finishes running on this :-)

@pitrou pitrou closed this in 78c278c Oct 24, 2019
pprudhvi added a commit to dremio/arrow that referenced this pull request Dec 9, 2019
Closes apache#5712 from pprudhvi/lower and squashes the following commits:

248a509 <Prudhvi Porandla> handle allocation failure in upper_utf8
dc11563 <Prudhvi Porandla> add unittest with utf8 chars
87c66e0 <Prudhvi Porandla> add lower

Authored-by: Prudhvi Porandla <prudhvi.porandla@icloud.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants