ARROW-6912: [Java] Extract a common base class for avro converter consumers#5740
Closed
tianchen92 wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-6912: [Java] Extract a common base class for avro converter consumers#5740tianchen92 wants to merge 2 commits intoapache:masterfrom
tianchen92 wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@emkornfield Hi, Micah, please take a look when you have time, thanks! |
emkornfield
reviewed
Oct 30, 2019
| import org.apache.arrow.vector.FieldVector; | ||
|
|
||
| /** | ||
| * Base class for all avro consumers. |
Contributor
There was a problem hiding this comment.
this doesn't include skipping consumers though? Update the comment?
Contributor
Author
|
@emkornfield could we merge this? I have a follow-up PR for logical types. |
Contributor
|
+1, thanks. |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…sumers Related to [ARROW-6912](https://issues.apache.org/jira/browse/ARROW-6912). Currently Avro converter consumers have some common variables and methods which could be eliminated by extracting a common class. Closes apache#5740 from tianchen92/ARROW-6912 and squashes the following commits: 74ffd54 <tianchen> update comments 53d7515 <tianchen> ARROW-6912: Extract a common base class for avro converter consumers Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6912.
Currently Avro converter consumers have some common variables and methods which could be eliminated by extracting a common class.