ARROW-7060: [R] Post-0.15.1 cleanup#5773
ARROW-7060: [R] Post-0.15.1 cleanup#5773nealrichardson wants to merge 9 commits intoapache:masterfrom
Conversation
| # ------------------------------------------------------------------------- | ||
| - name: R (with and without libarrow) | ||
| language: r | ||
| r: devel |
There was a problem hiding this comment.
Does it use a development version of R or does it enable development-specific options (such as debugging perhaps?)?
There was a problem hiding this comment.
The former. It installs a nightly build of R. It's important to test with R-devel in CI because CRAN checks package submissions against it, and the main reason for this patch is that there was an additional check in R-devel that arrow failed. We would have seen and fixed it three weeks ago if we'd been testing against R-devel.
There was a problem hiding this comment.
I see. But how do we check for regressions with stable releases of R (I assume that's important)?
There was a problem hiding this comment.
It is important, and we should do both, but if I only get to run one job, it should be the development version. You're much more likely to have something pass on the stable release and fail on devel than vice versa.
| if [ "$FORCE_AUTOBREW" != "TRUE" ] && [ "`command -v brew`" ] && [ "`brew ls --versions ${PKG_BREW_NAME}`" != "" ]; then | ||
| echo "Using Homebrew ${PKG_BREW_NAME}" | ||
| BREWDIR=$(brew --prefix) | ||
| BREWDIR=`brew --prefix` |
There was a problem hiding this comment.
Oh, we couldn't use $(...) on Solaris...
There was a problem hiding this comment.
Right, turns out we could not. This worked, though.
| homepage "https://arrow.apache.org/" | ||
| url "https://www.apache.org/dyn/closer.cgi?path=arrow/arrow-0.15.0.9000/apache-arrow-0.15.0.9000.tar.gz" | ||
| url "https://www.apache.org/dyn/closer.cgi?path=arrow/arrow-0.15.1.9000/apache-arrow-0.15.1.9000.tar.gz" | ||
| sha256 "9948ddb6d4798b51552d0dca3252dd6e3a7d0f9702714fc6f5a1b59397ce1d28" |
There was a problem hiding this comment.
Yes: the release tests expect that this version match the R package version in r/DESCRIPTION. I had to bump that in this PR because, unlike a normal release, the patch release branch wasn't merged, so the R version wasn't bumped. Normally this is done automatically in the release.
4 participants
The most substantive change here is revisions to
r/configurebased on a recently added CRAN check for bashisms. We could have caught that change earlier if we were running R tests on Travis with the latest development version of R, so this patch fixes that as well (even though we may not be using Travis for much longer).There is also some backfilling of
r/NEWS.mdsince I was already in the file.Leaving this as a draft PR until the CRAN submission is accepted, in case we need to revise further.