ARROW-7062: [C++][Dataset] Ensure ParquetFileFormat::Open catch parqu…#5789
Closed
fsaintjacques wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
…et's exception It also improves the error message by pointing which file is failing.
fsaintjacques
force-pushed
the
ARROW-7062-parquet-failures-should-propagate-filename
branch
from
bec2a06 to
82d9cd1
Compare
bkietz
approved these changes
Nov 8, 2019
| *out = fs; | ||
|
|
||
| return Status::OK(); | ||
| return fs; |
Member
There was a problem hiding this comment.
This will need a move on some platforms to avoid a spurious copy (and clang will sometimes emit a warning about it)
Suggested change
| return fs; | |
| return std::move(fs); |
Contributor
Author
There was a problem hiding this comment.
Every time I do this, I get a warning that it may disable RVO. Anyway, this is a mock class.
| ASSERT_EQ((message), _st.ToString()); \ | ||
| } while (false) | ||
|
|
||
| #define EXPECT_RAISES_WITH_MESSAGE_THAT(ENUM, matcher, expr) \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…et's exception
It also improves the error message by pointing which file is failing.