ARROW-7186: [R] Add inline comments to document the dplyr code#5847
Closed
nealrichardson wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-7186: [R] Add inline comments to document the dplyr code#5847nealrichardson wants to merge 3 commits intoapache:masterfrom
nealrichardson wants to merge 3 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to adding comments to help explain how the machinery works, this PR also improves the messaging when a user tries to filter Arrow data with an expression that isn't yet supported, and it raises an error when that happens on a Dataset instead of a warning, under the assumption that you want to explicitly control when to pull data from a big multi-file dataset. (https://issues.apache.org/jira/browse/ARROW-7095 is a followup to be more clever about unsupported expressions.)