ARROW-7169: [C++] Vendor uriparser library#5865
Closed
pitrou wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
Author
|
@kou Do you have any concerns? |
pitrou
force-pushed
the
ARROW-7169-vendor-uriparser
branch
from
095988c to
7abf071
Compare
pitrou
force-pushed
the
ARROW-7169-vendor-uriparser
branch
3 times, most recently
from
01cf4b2 to
0a1a1da
Compare
The library is only used internally (the types and headers are not exposed). Vendoring it makes it easier for core functionality to depend on it.
pitrou
force-pushed
the
ARROW-7169-vendor-uriparser
branch
from
0a1a1da to
83bb7c2
Compare
Member
|
@pitrou thanks for updating the packaging builds as well |
Member
Author
|
@kszucs Yes, I had forgotten to update some of them for the double-conversion vendoring. |
Member
|
Our nightlies are in pretty bad shape, so it would not make much sense to run them. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library is only used internally (the types and headers are not exposed).
Vendoring it makes it easier for core functionality to depend on it.